Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: use native fetch API #104

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

maschad
Copy link
Contributor

@maschad maschad commented Nov 6, 2023

Node 18 now has global fetch and given that electron now ships with node 18 by default , I don't think we need this peer-dependency anymore.

Related: #78

Copy link
Collaborator

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs to remove use of native-fetch as well, and just use the global fetch function.

CI still passes because native-fetch checks for the existence of global fetch first, but it's redundant now since all supported environments have a global fetch function.

@maschad maschad changed the title deps: remove undici as peer dep fix!: ruse native fetch API Nov 6, 2023
@maschad maschad changed the title fix!: ruse native fetch API fix!: use native fetch API Nov 6, 2023
@achingbrain achingbrain merged commit 58453c7 into vasco-santos:main Nov 6, 2023
16 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 6, 2023
## [3.0.0](v2.1.3...v3.0.0) (2023-11-06)

### ⚠ BREAKING CHANGES

* requires node 18+

### Bug Fixes

* use native fetch API ([#104](#104)) ([58453c7](58453c7))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants